Add Prototype-Refactor.js & Lambda-Classes.js #1
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 2 commits
October 10, 2019 07:10
Because: - Took existing code and made it modern - Worked with my prototypes assignment I guilt out yesterday This commit: - Converted all of my constructors into ES6 Classes using the class and extends keywords. - I was able to run my same logs and they built out the proper expected behaviors - Also used the super keyword to accces and call function on an object's parent - extends tell super where to go
Because: - We need to build a roster of LS personnel This commit: - Got used to thinking about classes in JS and built them from abrand new data set. - Created 2-3 objects for each class and tested them according to their unique Attributes. - Work in progress...
Because:
- There were some minor issues with console.log so I fixed it
This commit:
- Added a few more property and values to instructor and student objects
- Took out invokation that didn't need to be there
- Working on PRAssignment, a method that receives a subject as an argument and logs out that the student.name has submitted a PR for {subject}
Because: - Added all unique props for the instructor - Added one more student object This commit: - Extended the functionality of the Student by adding a property called grade and setting it equal to a number between 1-100 - Built a method on the Instructor (works for BOTH instructor and TL) that randomly add or subtract points to a student's grade. Used Math.random - Working on adding a graduate method to a student.
Because: - It's fun! This commit: - Extended the funcitonality of the Student by adding a property called grade and setiing it equal to a number between 1-100. - Built a method on the Instructor(for both instructor and TL) that randomly adds or subtracts points to a student's grade. Used Math.round and Math.random - Working on adding a graduate method to a student.
Because: - Would like to get 3 points! This commit: - Added a graduate method to a student. - This method, when called, will check the grade of the student and see it they're ready to graduate from LS - If the student's grade is above a 70%, they graduate! This part is working well. - Otherwise go back to grading their assignments to increase their score. This part is still work in progress
Because: - Added villain and hero constructor functions and objects from JS III This commit: - Took existing code and made it modern. - Converted villain and hero's constructors into ES6 Classes using the class, extends, and super keywords. - Was able to run my same logs and they built out the proper expected behaviors - Used the super keyword to access and call function on an object's parent - Extends tells Super where to go - Going to make my stretch goal codes better for lambda-classes.js now.
Because: - Updated the TL object from Dustin to Leigh This commit: - Was able to run my same logs and they built out the proper expected behaviors with Leigh's first name.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Because:
Took existing code and made it modern. Worked with my prototypes assignment I built out yesterday
We need to build a roster of LS personnel
This PR:
-Created 2-3 objects for each class and tested them according to their unique Attributes.