Skip to content

Conversation

@raul338
Copy link
Contributor

@raul338 raul338 commented Sep 27, 2020

Update the template array in FormHelper, added in 3.9 in cakephp/cakephp#13686

Otherwise it throws a RuntimeException when using MultipleCheckbox

@codecov
Copy link

codecov bot commented Sep 27, 2020

Codecov Report

Merging #192 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff            @@
##             master     #192   +/-   ##
=========================================
  Coverage     88.86%   88.86%           
  Complexity      368      368           
=========================================
  Files            19       19           
  Lines          1150     1150           
=========================================
  Hits           1022     1022           
  Misses          128      128           
Impacted Files Coverage Δ Complexity Δ
src/View/Helper/FormHelper.php 83.73% <ø> (ø) 53.00 <0.00> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update b839973...1210690. Read the comment docs.

@raul338
Copy link
Contributor Author

raul338 commented Sep 28, 2020

Yes, those should be in another commits, as I'm using cake 3 with bootstrap 3.

Maybe cherry-pick the commit?

@Holt59 Holt59 merged commit 116335b into CakePHP-Bootstrap:master Sep 29, 2020
@Holt59
Copy link
Collaborator

Holt59 commented Sep 29, 2020

These cannot be cherry-picked directly due to conflicts. I can make the change myself to the other branches but you can open PRs if you want to keep authorship on this.

@raul338
Copy link
Contributor Author

raul338 commented Sep 30, 2020

Thank you.
Nevermind about authorship, its just a line.

Maybe you should make a release with this fix? In the meantime it can be fixed by adding the line in the project's AppView

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants