Optimize pitcher plants - #3877
Draft
krabsticks1 wants to merge 2 commits into
Draft
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR adds some minor optimizations to pitcher plant models, which affect all Sodium versions they are present in (1.20.1, 1.21.1, 1.21.11, 26.1.x, 26.2.x). It makes the following changes:
pitcher_plantmodels. The vanilla model defines six faces per plane when only two are needed.pitcher_cropmodels. Unfortunately these will not cull against farmland blocks (which the crop can only be placed on in vanilla survival), but this might be useful to builders or mapmakers who can utilise the blocks more freely. It doesn't hurt to have them.I did not change the mapping of the affected models or the texture references, only the changes listed above. They should appear identical and this seemed to be the case in some quick testing I did.
I do have some questions about further changes to the model, so I will mark this as a draft for now and ask on the Discord.