Fix rendering of UP face for waterlogged blocks with translucent sides - #3775
Fix rendering of UP face for waterlogged blocks with translucent sides#3775Auth0x78 wants to merge 4 commits into
Conversation
…t side was not rendered
There was a problem hiding this comment.
I think it would be more appropriate if we used the voxel shape that we construct based on the fluid height for culling the fluid against the block that contains it. This voxel shape is used to cull the fluid against other blocks, and we could also use it to clear the fluid against its own block. Passing the fluid height into the shape comparison goes against the idea of the shape comparison system.
I appreciate your effort in resolving this issue, but I think there's a more appropriate solution than this.
|
I have done the necessary changes. I get that passing fluidHeight is redundant and defeats the whole point of shape comparision. So removed it from func parameter and so now before calling the main function for checking visibility of fluid with self we construct a VoxelShape that better represents the fluid block. Thank you for the feedback. |
|
@douira any other changes, I will make them |
|
I found that we dont require to manually calculate height and then construct VoxelShape for accurate fluid shape, we can simply query |
|
@douira any update on this PR or any changes I might need to do? Thanks |
3 participants
Occlude the UP face only when the waterlogged fluid height is below 1.0f, as the side faces may be translucent.
Issue resolved:
#3197