Skip to content

Commit 3f64af5

Browse files
committed
Merge pull request LogentriesCommunity#57 from eflanagan-r7/master
Now allows the user to choose between using TLS and non-TLS sockets
2 parents 4a00a2d + c21b713 commit 3f64af5

File tree

4 files changed

+11
-6
lines changed

4 files changed

+11
-6
lines changed

.gitignore

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1 @@
1+
*.pyc

logentries/utils.py

Lines changed: 7 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -125,10 +125,13 @@ def run(self):
125125

126126
self.close_connection()
127127

128+
SocketAppender = PlainTextSocketAppender
129+
128130
try:
129131
import ssl
132+
ssl_enabled = True
130133
except ImportError: # for systems without TLS support.
131-
SocketAppender = PlainTextSocketAppender
134+
ssl_enabled = False
132135
dbg("Unable to import ssl module. Will send over port 80.")
133136
else:
134137
class TLSSocketAppender(PlainTextSocketAppender):
@@ -150,14 +153,13 @@ def open_connection(self):
150153
do_handshake_on_connect=True,
151154
suppress_ragged_eofs=True,
152155
)
156+
153157
sock.connect((self.le_api, self.le_tls_port))
154158
self._conn = sock
155159

156-
SocketAppender = TLSSocketAppender
157-
158160

159161
class LogentriesHandler(logging.Handler):
160-
def __init__(self, token, force_tls=False, verbose=True, format=None, le_api=LE_API_DEFAULT, le_port=LE_PORT_DEFAULT, le_tls_port=LE_TLS_PORT_DEFAULT):
162+
def __init__(self, token, use_tls=True, verbose=True, format=None, le_api=LE_API_DEFAULT, le_port=LE_PORT_DEFAULT, le_tls_port=LE_TLS_PORT_DEFAULT):
161163
logging.Handler.__init__(self)
162164
self.token = token
163165
self.good_config = True
@@ -174,7 +176,7 @@ def __init__(self, token, force_tls=False, verbose=True, format=None, le_api=LE_
174176
'%a %b %d %H:%M:%S %Z %Y')
175177
self.setFormatter(format)
176178
self.setLevel(logging.DEBUG)
177-
if force_tls:
179+
if use_tls and ssl_enabled:
178180
self._thread = TLSSocketAppender(verbose=verbose, le_api=le_api, le_port=le_port, le_tls_port=le_tls_port)
179181
else:
180182
self._thread = SocketAppender(verbose=verbose, le_api=le_api, le_port=le_port, le_tls_port=le_tls_port)

setup.cfg

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,2 @@
1+
[egg_info]
2+
egg_base = /tmp

setup.py

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,4 +1,4 @@
1-
from distutils.core import setup
1+
from setuptools import setup
22

33
setup(
44
name='Logentries',

0 commit comments

Comments
 (0)