Skip to content

Add rotateAboutCenter regression test#982

Merged
adam-urbanczyk merged 1 commit into
CadQuery:masterfrom
lorenzncode:rotateAboutCenter
Feb 10, 2022
Merged

Add rotateAboutCenter regression test#982
adam-urbanczyk merged 1 commit into
CadQuery:masterfrom
lorenzncode:rotateAboutCenter

Conversation

@lorenzncode
Copy link
Copy Markdown
Member

Adding a simple test for rotateAboutCenter.

@codecov
Copy link
Copy Markdown

codecov Bot commented Feb 6, 2022

Codecov Report

Merging #982 (9e74c8f) into master (ccc8292) will increase coverage by 0.00%.
The diff coverage is 100.00%.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #982   +/-   ##
=======================================
  Coverage   96.17%   96.17%           
=======================================
  Files          40       40           
  Lines        9286     9290    +4     
  Branches     1109     1109           
=======================================
+ Hits         8931     8935    +4     
  Misses        208      208           
  Partials      147      147           
Impacted Files Coverage Δ
tests/test_cadquery.py 99.29% <100.00%> (+<0.01%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update ccc8292...9e74c8f. Read the comment docs.

Copy link
Copy Markdown
Member

@jmwright jmwright left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@lorenzncode Thanks, looks good.

@adam-urbanczyk
Copy link
Copy Markdown
Member

Thanks a lot @lorenzncode ! @jmwright shall we wait until azure things are sorted out?

@jmwright
Copy link
Copy Markdown
Member

jmwright commented Feb 8, 2022

shall we wait until azure things are sorted out?

Sure

@adam-urbanczyk
Copy link
Copy Markdown
Member

Thanks @lorenzncode !

@adam-urbanczyk adam-urbanczyk merged commit 997a277 into CadQuery:master Feb 10, 2022
@lorenzncode lorenzncode deleted the rotateAboutCenter branch October 2, 2022 17:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants