Additional constraints#975
Conversation
|
I did not add the new constraints yet, but @marcus7070 @lorenzncode could you take a look to see if the reworked version is more readable? |
Codecov Report
@@ Coverage Diff @@
## master #975 +/- ##
==========================================
+ Coverage 96.17% 96.26% +0.08%
==========================================
Files 40 40
Lines 9292 9341 +49
Branches 1109 1103 -6
==========================================
+ Hits 8937 8992 +55
+ Misses 208 205 -3
+ Partials 147 144 -3
Continue to review full report at Codecov.
|
+initial work on FixedPoint
Co-authored-by: Marcus Boyd <mwb@geosol.com.au>
marcus7070
left a comment
marcus7070
left a comment
There was a problem hiding this comment.
This looks fantastic @adam-urbanczyk, thanks so much for doing it!
Co-authored-by: Marcus Boyd <mwb@geosol.com.au>
Co-authored-by: Lorenz <hello@lorenz.space>
|
Ok, I think that this is it @jmwright @lorenzncode @marcus7070 . The only thin I don't really like is the automatic fixed constraint handling. Maybe in the future (not in this PR) we should require an explicit |
lorenzncode
left a comment
lorenzncode
left a comment
There was a problem hiding this comment.
I've added a few minor suggestions for docs, error messages.
jmwright
left a comment
jmwright
left a comment
There was a problem hiding this comment.
Looks good, thanks for all the work @adam-urbanczyk
I'm relying on @marcus7070 and @lorenzncode quite a bit for this review since it seems that they understand the subtleties of the constraint system better than I do.
Co-authored-by: Lorenz <hello@lorenz.space> Co-authored-by: Jeremy Wright <wrightjmf@gmail.com>
|
Great, I'll merge tomorrow. |
4 participants
Uh oh!
There was an error while loading. Please reload this page.