doc/assy: add constraints#850
Merged
Merged
Conversation
Contributor
|
It could be nice to have a note that says something like :
(I am not 100% sure this is true though lol) |
Member
Author
Thanks @Jojain. Yeah, I won't word it exactly like that (I think no initial locations is fine for the majority of uses), but if I'm explaining how constraints work then I should also explain initial locations as well. |
4 tasks
Member
|
@marcus7070 Still seeing the following black error in CI. |
adam-urbanczyk
approved these changes
Sep 1, 2021
Member
adam-urbanczyk
left a comment
There was a problem hiding this comment.
Great, looks good! Just one more black run and all should be green.
Member
Author
Thanks, I just had to add a comma to a list. Assuming this all passes I'll merge in a few minutes. |
Member
Author
|
Just a leftover error because this branch doesn't contain #872, so I'll merge. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Will resolve #715.
This is still a WIP, but it's mostly done and I won't be able to get back to it for a few days, so I figured I'd open this draft PR incase anyone wants to check it out.
Still to do:
Introduce dummy geometryIntroduce dummy Shapes in the assembly docs #856Explain why rotation has to be locked with PointInPlane, but you can get away without doing it for just PointNot going to add this, it reads better without itgen_colors.py, it's not obvious what it's used for