Skip to content

Move to OCP 7.5.2#818

Merged
adam-urbanczyk merged 1 commit into
masterfrom
OCP-7.5.2
Aug 4, 2021
Merged

Move to OCP 7.5.2#818
adam-urbanczyk merged 1 commit into
masterfrom
OCP-7.5.2

Conversation

@adam-urbanczyk
Copy link
Copy Markdown
Member

@adam-urbanczyk adam-urbanczyk commented Jul 7, 2021

Will resolve #697

@adam-urbanczyk adam-urbanczyk added infrastructure OCC feature Requires coding at OCC implementation level labels Jul 7, 2021
@codecov
Copy link
Copy Markdown

codecov Bot commented Jul 7, 2021

Codecov Report

Merging #818 (5b935d2) into master (6a440b6) will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #818   +/-   ##
=======================================
  Coverage   95.21%   95.21%           
=======================================
  Files          32       32           
  Lines        7489     7489           
  Branches      798      798           
=======================================
  Hits         7131     7131           
  Misses        221      221           
  Partials      137      137           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 6a440b6...5b935d2. Read the comment docs.

@jmwright
Copy link
Copy Markdown
Member

@adam-urbanczyk Is this ready to review?

@adam-urbanczyk
Copy link
Copy Markdown
Member Author

Not much to review, but I did not test this version extensively.

@adam-urbanczyk
Copy link
Copy Markdown
Member Author

@jmwright @marcus7070 shall we just pull the trigger on this?

@jmwright
Copy link
Copy Markdown
Member

jmwright commented Aug 2, 2021

shall we just pull the trigger on this?

@adam-urbanczyk Yes, we probably should.

@adam-urbanczyk
Copy link
Copy Markdown
Member Author

Alright, I'll merge tomorrow.

@marcus7070
Copy link
Copy Markdown
Member

Sorry, I missed my @ mention. LGTM, I've run CQ-editor with this and all looks normal too.

@adam-urbanczyk adam-urbanczyk merged commit 9b65709 into master Aug 4, 2021
@jmwright jmwright deleted the OCP-7.5.2 branch October 28, 2025 20:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

infrastructure OCC feature Requires coding at OCC implementation level

Projects

None yet

Development

Successfully merging this pull request may close these issues.

step exporter generates incorrect geometry

3 participants