Remove authors file#734
Merged
Merged
Conversation
RubenRubens
force-pushed
the
rm_authors_file
branch
from
c7b5a18 to
4370395
Compare
Codecov Report
@@ Coverage Diff @@
## master #734 +/- ##
=========================================
Coverage ? 94.56%
=========================================
Files ? 32
Lines ? 7218
Branches ? 786
=========================================
Hits ? 6826
Misses ? 257
Partials ? 135 Continue to review full report at Codecov.
|
Member
+1 for removing it and relying on GitHub's automatic contribution tracking instead. |
Member
|
+1 |
Member
|
@RubenRubens Thanks! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Currently, there are only two authors: Dave Cowden and Jeremy Wright. There is no mention to Adam Urbańczyk. So, we can add Adam to the file or just remove it. Anyone can already see the authors of CadQuery here.
Don't get me wrong, authors are import and the three leaders of CadQuery deserve recognition for their work. But I just feel like we should remove the file and move on.