Skip to content

Implement locationAt#404

Merged
adam-urbanczyk merged 2 commits into
masterfrom
locateAt
Jul 15, 2020
Merged

Implement locationAt#404
adam-urbanczyk merged 2 commits into
masterfrom
locateAt

Conversation

@adam-urbanczyk
Copy link
Copy Markdown
Member

@adam-urbanczyk adam-urbanczyk commented Jul 13, 2020 •
edited
Loading

This will resolve #389 . This is exposed only at shapes level, I don't think there is a elegant way to use expose this at the fluen api level.

Here is an example of what can be done with this functions. It can be very useful for modeling thread ends.
obraz

from cadquery import *

r = cq.Workplane().rect(3,1).extrude(0.1).faces('<Z').val()

s2 = Wire.makeHelix(7,20,5,angle=360).Edges()[0]
show_object(s2)
N = 20
locs = s2.Edges()[0].locations([0] + [i/N for i in range(1,N+1)])

show_object(Compound.makeCompound(r.located(l) for l in locs))

@codecov
Copy link
Copy Markdown

codecov Bot commented Jul 14, 2020 •
edited
Loading

Codecov Report

Merging #404 into master will increase coverage by 0.04%.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #404      +/-   ##
==========================================
+ Coverage   93.52%   93.56%   +0.04%     
==========================================
  Files          19       19              
  Lines        5048     5083      +35     
  Branches      520      523       +3     
==========================================
+ Hits         4721     4756      +35     
  Misses        205      205              
  Partials      122      122
Impacted Files Coverage Δ
cadquery/occ_impl/shapes.py 90.67% <100.00%> (+0.23%) ⬆️
tests/test_cadquery.py 98.97% <100.00%> (+0.01%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 747631f...bb63b48. Read the comment docs.

@adam-urbanczyk adam-urbanczyk changed the title Implement locationAt [WIP] Implement locationAt Jul 14, 2020
@adam-urbanczyk adam-urbanczyk requested a review from jmwright July 14, 2020 16:36
jmwright
jmwright approved these changes Jul 14, 2020
View reviewed changes
Copy link
Copy Markdown
Member

@jmwright jmwright left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, thanks!

@adam-urbanczyk
Copy link
Copy Markdown
Member Author

adam-urbanczyk commented Jul 15, 2020

OK, merging.

@adam-urbanczyk adam-urbanczyk merged commit a8707ce into master Jul 15, 2020
@jmwright jmwright mentioned this pull request Dec 31, 2020
Closed
@jmwright jmwright deleted the locateAt branch October 28, 2025 20:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@jmwright jmwright jmwright approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Support generating locations along a curve

2 participants

@adam-urbanczyk @jmwright