Better BuildCurves3d_s parameters in makeHelix#387
Merged
Conversation
Codecov Report
@@ Coverage Diff @@
## master #387 +/- ##
=======================================
Coverage 93.31% 93.31%
=======================================
Files 19 19
Lines 4847 4847
Branches 483 483
=======================================
Hits 4523 4523
Misses 210 210
Partials 114 114
Continue to review full report at Codecov.
|
Member
Author
|
I think this PR can be merged @jmwright . Current settings produce a correct result for at least 1000 turns: import cadquery as cq
R = 500 # helix radius
N = 1000 # helix turns - incorrect output for N > 42
P= 10 # helix pitch
w = cq.Wire.makeHelix(pitch=P, height=N*P, radius=R)
show_object(w)I think this is enough for a typical user. In the future we might want to assemble the final helix form multiple edges. |
Member
|
Thanks @adam-urbanczyk , merging. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This will resolve #385 . The parameters are chosen "experimentally", so future changes are possible.