Open
Conversation
This reverts commit f57f470.
Author
|
nevermind, I definitely didn't understand how the angle constraint worked, the wrap around was a mistake. I'll fix it as soon as possible, hopefully tomorrow. |
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #1983 +/- ##
==========================================
- Coverage 95.96% 95.95% -0.01%
==========================================
Files 29 29
Lines 7857 7896 +39
Branches 1174 1185 +11
==========================================
+ Hits 7540 7577 +37
- Misses 183 184 +1
- Partials 134 135 +1 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds the
EqualandEqualRadiusconstraints metioned in #1979.While I was writing the tests and adding small perturbations to test the solver I noticed that the optimizer would not converge for some
Angleconstraints. With the wrap around inangle_cost, the delta is always minimal and the solver converges. No tests broke and I couldn't think of any case in which this modification would actually change the already established behavior but I would ask for a double, triple check.