fix: Allow duplicate sub-assemblies#1963
Open
nathaniel-brough wants to merge 1 commit intoCadQuery:masterfrom
Open
fix: Allow duplicate sub-assemblies#1963nathaniel-brough wants to merge 1 commit intoCadQuery:masterfrom
nathaniel-brough wants to merge 1 commit intoCadQuery:masterfrom
Conversation
nathaniel-brough
force-pushed
the
push-kkslrsmvmqrq
branch
from
72ddb1f to
ad5cb92
Compare
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #1963 +/- ##
==========================================
- Coverage 95.84% 95.82% -0.03%
==========================================
Files 29 29
Lines 7922 7922
Branches 1191 1191
==========================================
- Hits 7593 7591 -2
- Misses 192 193 +1
- Partials 137 138 +1 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Member
|
Thanks for the contribution @nathaniel-brough . It should be implemented on the importer level though. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Attempts to fix: #1962