Update quickstart documentation inconsistencies#1871
Merged
Conversation
The referenced line numbers following the code-block in the More Holes section weren't pointing at the highlighted lines which I believe was not the intent, I updated it to what seemed correct. I also re-arranged some sections to follow the top-down flow the rest of the document seems to be following. I'm new this library and the CAD domain entirely so these stood out to my beginner's eyes. Really liking this project so far!
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #1871 +/- ##
=======================================
Coverage 95.66% 95.66%
=======================================
Files 28 28
Lines 7431 7431
Branches 1122 1122
=======================================
Hits 7109 7109
Misses 193 193
Partials 129 129 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
adam-urbanczyk
approved these changes
Jul 22, 2025
Member
|
LGTM, thanks @bayne |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The referenced line numbers following the code-block in the More Holes section weren't pointing at the highlighted lines which I believe was not the intent, I updated it to what seemed correct.
I also re-arranged some sections to follow the top-down flow the rest of the document seems to be following.
I'm new this library and the CAD domain entirely so these stood out to my beginner's eyes. Really liking this project so far!