Update changes and metadata for 2.5#1738
Merged
Merged
Conversation
Member
Author
|
This is it for 2.5 |
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #1738 +/- ##
=======================================
Coverage 95.33% 95.33%
=======================================
Files 28 28
Lines 6842 6842
Branches 1025 1025
=======================================
Hits 6523 6523
Misses 194 194
Partials 125 125 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
jmwright
approved these changes
Jan 1, 2025
Member
jmwright
left a comment
jmwright
left a comment
There was a problem hiding this comment.
Looks good, thanks @adam-urbanczyk ! If you send me your PyPI user name, I will get you added so you can push releases.
Member
Author
|
Done |
lorenzncode
approved these changes
Jan 1, 2025
Member
|
One other suggestion is to change the conda env detection in setup.py from:
The current check is not effective with micromamba. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
__init__.pysetup.py