Skip to content

Call SetLocation to set top Assembly Location#1623

Merged
adam-urbanczyk merged 5 commits into
CadQuery:masterfrom
lorenzncode:assy-setloc
Jul 8, 2024
Merged

Call SetLocation to set top Assembly Location#1623
adam-urbanczyk merged 5 commits into
CadQuery:masterfrom
lorenzncode:assy-setloc

Conversation

@lorenzncode
Copy link
Copy Markdown
Member

Fixes #1594.
Alternative fix of1594.

@codecov
Copy link
Copy Markdown

codecov Bot commented Jul 3, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 94.92%. Comparing base (9ee703d) to head (01a303e).
Report is 8 commits behind head on master.

Additional details and impacted files
@@           Coverage Diff           @@
##           master    #1623   +/-   ##
=======================================
  Coverage   94.91%   94.92%           
=======================================
  Files          28       28           
  Lines        6259     6263    +4     
  Branches     1271     1271           
=======================================
+ Hits         5941     5945    +4     
  Misses        192      192           
  Partials      126      126           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@lorenzncode
Copy link
Copy Markdown
Member Author

This seems more straightforward - prefer this over #1595 use of location multiplication?

This PR creates an additional label. The display of the tree view of an exported step in OCCT CAD Assistant or FreeCAD shows this as an additional tree item. Just to mention the representation is slightly different but I think this is expected OCCT behavior.

@adam-urbanczyk
Copy link
Copy Markdown
Member

This looks cleaner, thanks @lorenzncode ! I moved the code back into _toCAF`.

@adam-urbanczyk adam-urbanczyk requested a review from jmwright July 5, 2024 16:14
Copy link
Copy Markdown
Member

@jmwright jmwright left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. Thanks @lorenzncode !

@adam-urbanczyk adam-urbanczyk merged commit edabe5e into CadQuery:master Jul 8, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Assembly top level location ignored

3 participants