Call SetLocation to set top Assembly Location#1623
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #1623 +/- ##
=======================================
Coverage 94.91% 94.92%
=======================================
Files 28 28
Lines 6259 6263 +4
Branches 1271 1271
=======================================
+ Hits 5941 5945 +4
Misses 192 192
Partials 126 126 ☔ View full report in Codecov by Sentry. |
|
This seems more straightforward - prefer this over #1595 use of location multiplication? This PR creates an additional label. The display of the tree view of an exported step in OCCT CAD Assistant or FreeCAD shows this as an additional tree item. Just to mention the representation is slightly different but I think this is expected OCCT behavior. |
|
This looks cleaner, thanks @lorenzncode ! I moved the code back into _toCAF`. |
jmwright
left a comment
There was a problem hiding this comment.
Looks good. Thanks @lorenzncode !
Fixes #1594.
Alternative fix of1594.