Fix documentation hole, to many parameter#1492
Merged
Merged
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #1492 +/- ##
=======================================
Coverage 94.44% 94.44%
=======================================
Files 28 28
Lines 5774 5774
Branches 1070 1070
=======================================
Hits 5453 5453
Misses 194 194
Partials 127 127 ☔ View full report in Codecov by Sentry. |
Member
|
Thanks @jlombacher Why do you set |
Contributor
Author
Good point just removed it. |
jmwright
approved these changes
Jan 18, 2024
Member
jmwright
left a comment
jmwright
left a comment
There was a problem hiding this comment.
Thanks @jlombacher
Simple change and I have confirmed that the example was broken before. Merging.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Just minor, but was confusing to me