Add "Fixed" to ConstraintKinds type definition#1177
Merged
jmwright merged 2 commits intoOct 12, 2022
Conversation
Codecov Report
@@ Coverage Diff @@
## master #1177 +/- ##
==========================================
- Coverage 94.01% 94.01% -0.01%
==========================================
Files 26 26
Lines 5411 5410 -1
Branches 918 918
==========================================
- Hits 5087 5086 -1
Misses 193 193
Partials 131 131
📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
Member
|
@adam-urbanczyk @lorenzncode I feel like you two are best suited to review constraints PRs, so I went ahead and added you both as reviewers on this. |
lorenzncode
reviewed
Oct 10, 2022
Member
lorenzncode
left a comment
lorenzncode
left a comment
There was a problem hiding this comment.
I'd suggest to add ConstraintKind to the imports from occ_impl.solver along with the already imported UnaryConstraintKind, BinaryConstraintKind.
sethfischer
force-pushed
the
typing-add-fixed-to-constraint-kinds
branch
from
2af2f02 to
1f35de8
Compare
Member
|
@sethfischer It looks like the black lint check is failing. |
sethfischer
force-pushed
the
typing-add-fixed-to-constraint-kinds
branch
from
1f35de8 to
a252c2a
Compare
adam-urbanczyk
approved these changes
Oct 11, 2022
Member
|
LGTM if CI passes. |
Member
|
Thanks @sethfischer! FYI, the black check requires version 19.10b0. |
lorenzncode
approved these changes
Oct 12, 2022
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.