Do not recompute normals when converting to vtk#1167
Merged
Conversation
Codecov Report
@@ Coverage Diff @@
## master #1167 +/- ##
=======================================
Coverage 94.01% 94.01%
=======================================
Files 26 26
Lines 5411 5411
Branches 918 918
=======================================
Hits 5087 5087
Misses 193 193
Partials 131 131
📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
|
Thank you very much, this seems to have solved the problem reported in #1158. |
lorenzncode
approved these changes
Oct 6, 2022
Member
lorenzncode
left a comment
lorenzncode
left a comment
There was a problem hiding this comment.
'box-has-back-face-culling-issues.wrl' before fix (here in blender with WeightedNormal):
with this PR:
jmwright
approved these changes
Oct 6, 2022
Member
jmwright
left a comment
jmwright
left a comment
There was a problem hiding this comment.
Thanks @adam-urbanczyk Looks good.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Solves #1158