allow specification of dxf layer names to import. for issue #1051#1061
Conversation
|
That check failure is from black. Shall I |
Please use version specified in https://github.com/CadQuery/cadquery/blob/master/environment.yml |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #1061 +/- ##
=======================================
Coverage 96.32% 96.32%
=======================================
Files 40 40
Lines 9648 9672 +24
Branches 1272 1280 +8
=======================================
+ Hits 9293 9317 +24
Misses 210 210
Partials 145 145 ☔ View full report in Codecov by Sentry. |
|
@greyltc I fixed the mypy issue. Could you add a test? |
|
@greyltc do you plan to work on this PR? |
|
I had made part of these changes 2 months ago but at the time the PR didn't appear ready to review so I shelved them. Anyway it would be good to close the issue (with squash I think ideally). |
|
LGTM, thanks @greyltc and @lorenzncode ! |
No description provided.