Add shouldSelect option in togglePresentedDate method#606
Open
yoobato wants to merge 2 commits into
Open
Conversation
|
This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs within the next 7 days. Thank you for your contributions. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add
shouldSelectoption parameter intogglePresentedDatemethod.This determines whether
selectDayViewWithDaymethod where is in the end oftogglePresentedDatemethod should be called or not.I set
trueas default value for shouldSelect to support legacy codes.AS-IS (CVCalendarContentViewController)
@objc public func togglePresentedDate(_ date: Foundation.Date) { }TO-BE
@objc public func togglePresentedDate(_ date: Foundation.Date, shouldSelect: Bool = true) { }This may helps #251 although it's closed.