Hotfix/fix ios10 bug#154
Open
Calvin-Huang wants to merge 2 commits into
Open
Conversation
…ch cell, thus, there will be some header will not visible in screen and it can not be initialise by calling "layoutAttributesForSupplementaryViewOfKind". In here, add a check to make sure header is visible to prevent assertion failure. - https://developer.apple.com/videos/play/wwdc2016/219/
Contributor
|
It still crashes here. Not the first time but the second time it crashed. I'm you are on the right track, but we should investigate the crash a bit more before merging |
|
Seeing crashes due to the same issue (I think). Disabling prefetching on the UICollectionView seems to avoid the issue for now - but would love to see a fix for this! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
In iOS 10, UICollectionView & UITableView has the mechanism to prefetch cell, thus, there will be some header will not visible in screen and it can not be initialise by calling "layoutAttributesForSupplementaryViewOfKind".
In here, add a check to make sure header is visible to prevent assertion failure.