Upgrade from Java 9 (1.9) to Java 11#1
Open
devin-ai-integration[bot] wants to merge 1 commit intomasterfrom
Open
Upgrade from Java 9 (1.9) to Java 11#1devin-ai-integration[bot] wants to merge 1 commit intomasterfrom
devin-ai-integration[bot] wants to merge 1 commit intomasterfrom
Conversation
- Replace <source>1.9</source>/<target>1.9</target> with <release>11</release> - Add <java.version>11</java.version> property - Upgrade maven-compiler-plugin from 3.1 to 3.8.1 - Pin maven-shade-plugin to version 3.2.4 - Upgrade JMH (jmh-core, jmh-generator-annprocess) from 1.17.4 to 1.37 - Upgrade JUnit from 4.11 to 4.13.2 Jira: AB-55 Co-Authored-By: Abhay Aggarwal <abhay.aggarwal@codeium.com>
Author
🤖 Devin AI EngineerI'll be helping with this pull request! Here's what you should know: ✅ I will automatically:
Note: I can only respond to comments from users who have write access to this repository. ⚙️ Control Options:
|
![devin-ai-integration[bot]](https://avatars.githubusercontent.com/in/811515?s=60&v=4){kind=small}
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Upgrades the project from Java 9 to Java 11 by updating
pom.xmlonly. No source code changes were required — the codebase has no usage of removed Java EE modules (javax.xml.bind,javax.xml.ws) or internal JDK APIs (sun.misc.*,sun.reflect.*).Build configuration:
<source>1.9</source>/<target>1.9</target>with<release>11</release>(stricter — also validates API usage against JDK 11)<java.version>11</java.version>propertymaven-compiler-plugin3.1 → 3.8.1Dependency upgrades:
jmh-core,jmh-generator-annprocess) 1.17.4 → 1.37maven-shade-pluginto 3.2.4 (was previously unpinned)Validated:
mvn clean verifypasses with zero compilation errors on Java 11.Review & Testing Checklist for Human
mvn clean verifyon your Java 11 environment to confirm compilation and packaging succeedjava -jar target/benchmarks.jar) to verify the JMH 1.17→1.37 upgrade didn't break benchmark execution — this was a large version jump and there are no automated tests covering it<release>11</release>flag behavior is acceptable — unlike<source>/<target>, it also restricts API usage to the target JDK, which could surface compile errors if code accidentally used Java 12+ APIs in the futureNotes
<java.version>11</java.version>property is informational only — it is not referenced elsewhere in the pom. This is a common Maven convention but has no functional effect here.src/test/), somvn testreports "No tests to run." The only build validation is successful compilation and shade packaging.Link to Devin session: https://app.devin.ai/sessions/aee056c5f98f478a850c69083dbe399f
Requested by: @abhay-codeium