add design system files #3
Conversation
sass/_variables.scss
Outdated
| $query-connector-max-width: 45rem; | ||
| $query-connector-wide-max-width: 90rem; | ||
| $query-connector-content-margins: 13.75rem; | ||
| $query-connector-content-margins-wide: 10rem; | ||
| $query-connector-content-width-wide: calc( | ||
| $query-connector-wide-max-width - 2 * $query-connector-content-margins-wide | ||
| ); |
There was a problem hiding this comment.
should these still be in here? or renamed to dibbs or similar?
There was a problem hiding this comment.
Ah yes, will ask the designers if these are system level defaults or should be something set at the project level. Changed the naming for now
sass/_variables.scss
Outdated
| $query-connector-max-width: 45rem; | ||
| $query-connector-wide-max-width: 90rem; | ||
| $query-connector-content-margins: 13.75rem; | ||
| $query-connector-content-margins-wide: 10rem; | ||
| $query-connector-content-width-wide: calc( | ||
| $query-connector-wide-max-width - 2 * $query-connector-content-margins-wide | ||
| ); |
There was a problem hiding this comment.
Should we change $query-connector-* to something more generic? Maybe $app-* or $dibbs-app-*?
mcmcgrath13
left a comment
mcmcgrath13
left a comment
There was a problem hiding this comment.
a couple minor nits, but as this is a living-starting-place-document, I think we can go ahead and merge and continue to iterate as we implement and learn
thanks for pulling this together!
kevinfiol
left a comment
kevinfiol
left a comment
There was a problem hiding this comment.
To echo @mcmcgrath13 , I'm comfortable with moving forward with this in its current state and iterating as we implement the styles. Thanks for your work on this!
Initial setup for the design system overrides, including a writeup for the repo itself