fix: apply phone alias to recipients lists - #41
Open
Arshgill01 wants to merge 1 commit into
Open
Arshgill01 wants to merge 1 commit into
Arshgill01 wants to merge 1 commit into
Conversation
The TypeScript SDK maps phone to phones on every recipient object. Python only did that for the singular recipient= argument. Co-authored-by: Cursor <cursoragent@cursor.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
Map every item in
recipients=through_normalize_recipient, sorecipients=[{"phone": "+14155550100"}]becomes wire[{"phones": ["+14155550100"]}], matchingrecipient={"phone": ...}and the TypeScript SDK.Why
create()only normalized the singularrecipient=kwarg:OpenAPI
CallTaskRecipientRequestrequiresphonesand setsadditionalProperties: false. A TypeScript snippet ported asrecipients=[{"phone": "..."}]sends an illegalphonekey.This is the one-liner alias only. Extra keys are still forwarded (existing
_normalize_recipientbehavior).Evidence
Offline
respxmock. No live POST/v1/calls.test_create_call_aliases_phone_on_recipients_listasserts the request body recipients are[{"phones": ["+14155550100"], "region": "US", "locale": "en-US"}].Test
uv run --locked pytest -q tests/test_calls.pyas above.Source
From the CALL-E hackathon feedback lab: https://github.com/Arshgill01/ExactRef/blob/main/docs/feedback/lab/XR-110-python-recipients-skip-phone-alias.md
Made with Cursor