Skip to content

fix: keep polling wait_for_result on call_not_ready #40

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
Arshgill01 wants to merge 1 commit into
base: main
Choose a base branch
from
+38 −4
Open

fix: keep polling wait_for_result on call_not_ready #40

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 5 additions & 0 deletions CHANGELOG.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -7,6 +7,11 @@ and this project follows [Semantic Versioning](https://semver.org/spec/v2.0.0.ht

## [Unreleased]

### Fixed

- `CalleCalls.wait_for_result` keeps polling when GET returns `call_not_ready`
instead of treating that documented "not terminal yet" code as a hard failure.

## [0.7.1] - 2026-09-04

### Added
Expand Down
13 changes: 9 additions & 4 deletions src/calle/calls.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4,7 +4,7 @@

import httpx

from calle.errors import CalleConnectionError, CalleTimeoutError, api_error_from_response
from calle.errors import CalleAPIError, CalleConnectionError, CalleTimeoutError, api_error_from_response


JsonObject = dict[str, Any]
Expand Down Expand Up @@ -56,9 +56,14 @@ def wait_for_result(
) -> JsonObject:
deadline = time.monotonic() + timeout_seconds
while time.monotonic() <= deadline:
call = self.get(call_id)
if call.get("status") in {"completed", "failed", "canceled"}:
return call
try:
call = self.get(call_id)
except CalleAPIError as exc:
if exc.code != "call_not_ready":
raise
else:
if call.get("status") in {"completed", "failed", "canceled"}:
return call
time.sleep(interval_seconds)
raise CalleTimeoutError(f"Timed out waiting for CALL-E call {call_id}.")

Expand Down
24 changes: 24 additions & 0 deletions tests/test_calls.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -153,6 +153,30 @@ def test_wait_for_result_returns_failed_call() -> None:
assert call["failure_code"] == "no_answer"


@respx.mock
def test_wait_for_result_retries_call_not_ready() -> None:
route = respx.get("https://api.heycall-e.com/v1/calls/call_123").mock(
side_effect=[
httpx.Response(
409,
json={
"error": {
"code": "call_not_ready",
"message": "The call task has not reached a terminal state.",
}
},
),
httpx.Response(200, json=COMPLETED_CALL),
]
)
client = CalleClient(api_key="key_test", base_url="https://api.heycall-e.com")

call = client.calls.wait_for_result("call_123", interval_seconds=0.001, timeout_seconds=0.5)

assert call["status"] == "completed"
assert route.call_count == 2


@respx.mock
def test_wait_for_result_raises_timeout() -> None:
queued = {**COMPLETED_CALL, "status": "queued", "structured_result": None, "completed_at": None}
Expand Down