fix: no longer automatically execute cachetool task#104
Closed
stijnbernards wants to merge 1 commit intoByteInternet:masterfrom
Closed
fix: no longer automatically execute cachetool task#104stijnbernards wants to merge 1 commit intoByteInternet:masterfrom
stijnbernards wants to merge 1 commit intoByteInternet:masterfrom
Conversation
tdgroot
requested changes
Jun 28, 2024
Member
tdgroot
left a comment
tdgroot
left a comment
There was a problem hiding this comment.
Good suggestion, I agree that this should be optional! Some of our customers are actually relying on cachetool because they manually opted for disabling opcache revalidation so let's keep the task in here, but make it optional.
| public function register(): void | ||
| { | ||
| after('deploy:symlink', 'cachetool:clear:opcache'); | ||
| after('cachetool:clear:opcache', 'cachetool:cleanup'); |
Member
There was a problem hiding this comment.
I think the after after('cachetool:clear:opcache' can remain, because when you actually make use of that task, you don't need to think about the cleanup.
Otherwise, I agree that this should be optional!
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Issue
Currently the Hypernode deploy always executes the cachetool opcache flush task.
This task is extremely flakey and fails a lot on our end. Same issue as on the Hipex servers.
Solution
This task can be safely removed, or at least marked optional as it's not required on Hypernode.
For reference see: https://deployer.org/docs/7.x/avoid-php-fpm-reloading
And in the Hypernode NGINX configuration
/etc/nginx/fastcgi_paramsthe following linefastcgi_param SCRIPT_FILENAME $realpath_root$fastcgi_script_name;Which makes it so that no longer opcache has to be flushed.
I've tested this and validated this on multiple customers on our end.