Chore/bump isolated vm #4145

Battjmo · 2025-09-16T19:04:00Z

Description

Bump isolated-vm to version 6.x.x, which supports Node 24: https://github.com/laverdet/isolated-vm?tab=readme-ov-file. I took a look through the commits on that release and didn't see anything that looked like it would impact functionality. The tests in the React package seem to all be borked on main so I can't confirm, took a stab at updating the contributing docs in there too to use yarn instead of npm.

I only did it in the React package since I don't want to get too far into the weeds and that's the one I use on my project.

Note

Upgrade isolated-vm to v6 and move tooling to Node 24, introducing major version bumps (dropping Node 18/20) across SDKs with minor doc updates.

Dependencies:
- Bump isolated-vm to ^6.0.0 across @builder.io/react and all Gen1/Gen2 SDK packages (@builder.io/sdk-{react,react-native,react-nextjs,qwik,solid,svelte,vue,angular}); update yarn.lock.
CI/Tooling:
- Update all GitHub Actions workflows to use Node 24.x; set .nvmrc to v24.4.1.
Releases/Versioning:
- Add changeset marking major releases for most SDKs and minor for @builder.io/sdk-{react-nextjs,qwik} with a breaking change: drop Node 18/20 support; add Node 24 support.
Docs:
- Update React CONTRIBUTING.md to use yarn instead of npm and link to v2 contribution guide.

^{Written by Cursor Bugbot for commit bf87407. This will update automatically on new commits. Configure here.}

changeset-bot · 2025-09-16T19:04:05Z

🦋 Changeset detected

Latest commit: bf87407

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 9 packages

Name	Type
@builder.io/react	Major
@builder.io/sdk-angular	Major
@builder.io/sdk-react-nextjs	Major
@builder.io/sdk-qwik	Major
@builder.io/sdk-react	Major
@builder.io/sdk-react-native	Major
@builder.io/sdk-solid	Major
@builder.io/sdk-svelte	Major
@builder.io/sdk-vue	Major

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

samijaber · 2025-09-18T15:12:58Z

@Battjmo does the install work on your machine? It seems to now break in CI for v6.x

If yes, what node version are you using?

Battjmo · 2025-09-18T21:35:33Z

@Battjmo does the install work on your machine? It seems to now break in CI for v6.x

If yes, what node version are you using?

Yep, build worked in the react package, Node v24.4.1 or v22.12.0

v6 of what? I'm getting version 8.2.6 in the build output for the SDK version.

samijaber · 2025-09-22T13:33:18Z

@Battjmo does the install work on your machine? It seems to now break in CI for v6.x
If yes, what node version are you using?

Yep, build worked in the react package, Node v24.4.1 or v22.12.0

v6 of what? I'm getting version 8.2.6 in the build output for the SDK version.

bumping isolated-vm to v6.0.0 fails in our CI, see https://github.com/BuilderIO/builder/actions/runs/17800387929/job/50623875294?pr=4145#step:4:584

I think it's because our CI is using node v18

builder/.github/workflows/ci.yml

Lines 29 to 33 in f5a63e7

    
           - name: Use Node.js 
        
             uses: actions/setup-node@v4 
        
             with: 
        
               node-version: '18.x'

whereas isolated-vm v6 expects node >=22 https://github.com/laverdet/isolated-vm/blob/5dc622865679323a6b68dca7762e49d82d7f67ff/package.json#L7-L9

so i think this PR needs to also bump the node version across the board (all github .yml workflows, and .nvmrc)

builder/.nvmrc

Line 1 in f5a63e7

v18.20.6

Battjmo · 2025-09-23T14:18:16Z

@Battjmo does the install work on your machine? It seems to now break in CI for v6.x
If yes, what node version are you using?

Yep, build worked in the react package, Node v24.4.1 or v22.12.0
v6 of what? I'm getting version 8.2.6 in the build output for the SDK version.

bumping isolated-vm to v6.0.0 fails in our CI, see https://github.com/BuilderIO/builder/actions/runs/17800387929/job/50623875294?pr=4145#step:4:584

I think it's because our CI is using node v18

builder/.github/workflows/ci.yml

Lines 29 to 33 in f5a63e7

- name: Use Node.js

uses: actions/setup-node@v4

with:

node-version: '18.x'

whereas isolated-vm v6 expects node >=22 https://github.com/laverdet/isolated-vm/blob/5dc622865679323a6b68dca7762e49d82d7f67ff/package.json#L7-L9

so i think this PR needs to also bump the node version across the board (all github .yml workflows, and .nvmrc)

builder/.nvmrc

Line 1 in f5a63e7

v18.20.6

Makes sense, about time we get this thing off of 18 anyway. I'll get cracking on it.

sidmohanty11 · 2025-09-24T06:42:38Z

thanks for the PR @Battjmo! 🚀

Battjmo · 2025-09-24T14:47:17Z

Alright, I went ahead and disregarded my previous statement about not updating everything and just updated everything. Come ooooooon ci.

nx-cloud · 2025-09-24T15:09:40Z

View your CI Pipeline Execution ↗ for commit bf87407

Command	Status	Duration	Result
`nx test @e2e/nextjs-sdk-next-app`	✅ Succeeded	7m 42s	View ↗
`nx test @e2e/qwik-city`	✅ Succeeded	7m 29s	View ↗
`nx test @e2e/react`	✅ Succeeded	7m 12s	View ↗
`nx test @e2e/nuxt`	✅ Succeeded	6m 58s	View ↗
`nx test @e2e/angular-17`	✅ Succeeded	6m 55s	View ↗
`nx test @e2e/gen1-react`	✅ Succeeded	4m 39s	View ↗
`nx test @e2e/gen1-next15-app`	✅ Succeeded	6m 20s	View ↗
`nx test @e2e/react-sdk-next-15-app`	✅ Succeeded	5m 38s	View ↗
`Additional runs (37)`	✅ Succeeded	...	View ↗

☁️ Nx Cloud last updated this comment at 2025-11-05 16:24:19 UTC

Battjmo · 2025-09-24T21:50:42Z

All of the tests in /sdks pass for me locally. Pushed up this fix that I think might help, can't confirm since it works for me locally regardless.

Battjmo · 2025-09-25T18:00:12Z

Alright, I'm a little confused by the output here. It looks like I passed CI but maybe also not? @samijaber ?

samijaber

@Battjmo This PR is looking good!

You can ignore the failing "E2E Snippets" CI flows. The only problematic CI error is the "Webcomponents" build CI run: https://github.com/BuilderIO/builder/actions/runs/18570204192/job/53036430895?pr=4145

You can likely resolve that by reverting the node version bump for it:

builder/.github/workflows/ci.yml

Lines 280 to 294 in 220b988

    
           build: 
        
             runs-on: ubuntu-latest 
        
             strategy: 
        
               fail-fast: false 
        
               matrix: 
        
                 package: ['webcomponents', 'widgets'] 
        
             steps: 
        
               - uses: actions/checkout@v4 
        
               - name: Use node version 18 
        
                 uses: actions/setup-node@v4 
        
                 with: 
        
                   node-version: '18.x'

since webcomponents still uses an old isolated-vm version (which wont be upgraded by this PR)

Battjmo · 2025-10-31T14:32:40Z

@Battjmo This PR is looking good!

You can ignore the failing "E2E Snippets" CI flows. The only problematic CI error is the "Webcomponents" build CI run: https://github.com/BuilderIO/builder/actions/runs/18570204192/job/53036430895?pr=4145

You can likely resolve that by reverting the node version bump for it:

builder/.github/workflows/ci.yml

Lines 280 to 294 in 220b988

build:

runs-on: ubuntu-latest

strategy:

fail-fast: false

matrix:

package: ['webcomponents', 'widgets']

steps:

- uses: actions/checkout@v4

- name: Use node version 18

uses: actions/setup-node@v4

with:

node-version: '18.x'

since webcomponents still uses an old isolated-vm version (which wont be upgraded by this PR)

@samijaber done!

Battjmo · 2025-11-03T19:59:40Z

@samijaber alright we're down to just snippets falling over.

samijaber

Brilliant, thanks a lot @Battjmo! ⚡

.changeset/many-bobcats-wave.md

Battjmo mentioned this pull request Sep 17, 2025

Bug: @builder.io/react fails to install on Node.js 24+ due to C++20 compilation requirements #4137

Open

Battjmo added 8 commits October 16, 2025 10:41

chore: bump isolate-vm to v6

8390d10

chore: update contributing guidelines

c089c36

chore: add changeset

b4ad8ed

chore: bump node version in CI

11d0f16

fix: add other github ymls

7400728

fix: update more packages

7049848

chore: update contributing guide for react package

78b5a3b

fix: found a stray node 18

0cadc34

Battjmo force-pushed the chore/bump-isolated-vm branch from 4356787 to 0cadc34 Compare October 16, 2025 17:49

This comment was marked as outdated.

Sign in to view

typo

38b8df7

alexbuilderio requested review from a team and sanyamkamat and removed request for a team October 19, 2025 21:14

samijaber reviewed Oct 30, 2025

View reviewed changes

Battjmo added 2 commits October 31, 2025 07:31

fix: revert webcomponents version to 18

7815e96

Merge branch 'main' into chore/bump-isolated-vm

29fbb95

samijaber approved these changes Nov 5, 2025

View reviewed changes

samijaber reviewed Nov 5, 2025

View reviewed changes

.changeset/many-bobcats-wave.md Outdated Show resolved Hide resolved

Apply suggestion from @samijaber

0f8dc62

samijaber reviewed Nov 5, 2025

View reviewed changes

.changeset/many-bobcats-wave.md Outdated Show resolved Hide resolved

Apply suggestion from @samijaber

bf87407

samijaber merged commit ba80951 into BuilderIO:main Nov 5, 2025
48 checks passed

	build:
	runs-on: ubuntu-latest

	strategy:
	fail-fast: false
	matrix:
	package: ['webcomponents', 'widgets']

	steps:
	- uses: actions/checkout@v4

	- name: Use node version 18
	uses: actions/setup-node@v4
	with:
	node-version: '18.x'

Chore/bump isolated vm #4145

Chore/bump isolated vm #4145

Conversation

Battjmo commented Sep 16, 2025 • edited by cursor bot Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Description

Uh oh!

changeset-bot bot commented Sep 16, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

🦋 Changeset detected

Uh oh!

samijaber commented Sep 18, 2025

Uh oh!

Battjmo commented Sep 18, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

samijaber commented Sep 22, 2025

Uh oh!

Battjmo commented Sep 23, 2025

Uh oh!

sidmohanty11 commented Sep 24, 2025

Uh oh!

Battjmo commented Sep 24, 2025

Uh oh!

nx-cloud bot commented Sep 24, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Battjmo commented Sep 24, 2025

Uh oh!

Battjmo commented Sep 25, 2025

Uh oh!

This comment was marked as outdated.

Uh oh!

samijaber left a comment

Choose a reason for hiding this comment

Uh oh!

Battjmo commented Oct 31, 2025

Uh oh!

Battjmo commented Nov 3, 2025

Uh oh!

samijaber left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

Battjmo commented Sep 16, 2025 •

edited by cursor bot

Loading

changeset-bot bot commented Sep 16, 2025 •

edited

Loading

Battjmo commented Sep 18, 2025 •

edited

Loading

nx-cloud bot commented Sep 24, 2025 •

edited

Loading