Avoid Git executable check during package import - #639
Draft
Mirochill wants to merge 2 commits into
Draft
Conversation
BradenM
force-pushed
the
fix-619-lazy-git-import
branch
from
June 20, 2026 18:13
bdc0449 to
82bff3a
Compare
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #639 +/- ##
==========================================
+ Coverage 91.36% 91.79% +0.43%
==========================================
Files 50 52 +2
Lines 2756 2828 +72
==========================================
+ Hits 2518 2596 +78
+ Misses 238 232 -6
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
BradenM
requested changes
Jun 20, 2026
Comment on lines
-99
to
+98
| self._repo: Optional[Repo] = None | ||
| self._repo: Optional[Any] = None |
Owner
There was a problem hiding this comment.
Preserve type hints:
if TYPE_CHECKING:
from git import Repo
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #619.
Summary
Repountil a VCS dependency is actually fetchedmicropy.packages.source_packagewith a brokengitmoduleValidation
git diff --checkpyproject.toml changed significantly since poetry.lock was last generated; macOS-12 Test MicropyCli jobs are still queued.