You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Thank you @kmoj86 for the work you put into this. A couple of questions:
Does everything generally work okay? From my understanding Arabic is a right-to-left language so I would have expected more work to be required to support such a language.
Is it okay if I squash this before merging? Just to reduce the amount of commits that will be merged for a cleaner history. Will still show as yourself being the author.
yes, everything works ok. but it's not the ideal way to view the application in Arabic. for best results, the CSS and text editor need to be configured for RTL. CSS only needs to be mirrored for the most part, the text editor on the other hand has to be reconfigured to handle RTL languages (Froala's WYSIWYG editor as an example).
But nothing that renders the app unusable. I've already tested it and found no issues with it.
That being said, this is a step forward in supporting Arabic language by translating the user interface, so anyone who doesn't speak a second language can use the application. and if one day a more experienced contributor comes to add RTL support for a better user experience, then the translation will already be here for them to use. In short: yes, everything is mostly ok 😄
sure thing! you can squash this for a cleaner history.
this is my first pull request and I've been working on the translation on 2 different PCs, so sorry for the mess.
@ssddanbrown
Great! thanks for all your work!
I tried to add rtl support myself by adding directionality plugin for TinyMCE, but for some reason it just didn't work for me. so this is really great news!
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
hope this will help more people to use this application 😃