Skip to content

Books page as application home page - #830

Merged
ssddanbrown merged 6 commits into
masterfrom
feature/615
May 20, 2018
Merged

ssddanbrown merged 6 commits into
masterfrom
feature/615

Conversation

@Abijeet

@Abijeet Abijeet commented May 10, 2018

Copy link
Copy Markdown
Member

Closes #615

Abijeet added 3 commits May 9, 2018 08:26
Signed-off-by: Abijeet <abijeetpatro@gmail.com>
Signed-off-by: Abijeet <abijeetpatro@gmail.com>
@Abijeet Abijeet changed the title [WIP] - Books page as application home page Books page as application home page May 12, 2018
Signed-off-by: Abijeet <abijeetpatro@gmail.com>
@Abijeet

Abijeet commented May 12, 2018

Copy link
Copy Markdown
Member Author

@ssddanbrown - Ready for review.

Let me know if you'd like me to make any changes in the code.

Few items tested,

  1. Setting the books page as homepage override the custom homepage option.
  2. Book view toggle on home page works properly.
  3. Removing the book homepage option reverts back to the previous home page.

@Abijeet
Abijeet requested a review from ssddanbrown May 12, 2018 10:10
@ssddanbrown ssddanbrown mentioned this pull request May 12, 2018
Abijeet added 2 commits May 12, 2018 17:28
Signed-off-by: Abijeet <abijeetpatro@gmail.com>
Signed-off-by: Abijeet <abijeetpatro@gmail.com>
@Abijeet

Abijeet commented May 12, 2018

Copy link
Copy Markdown
Member Author

Made a couple of minor adjustments based on some of the issues I found.

@mendiromania

Copy link
Copy Markdown

Great work as always Abijeet!

@ssddanbrown
ssddanbrown merged commit 28823c4 into master May 20, 2018
@ssddanbrown

Copy link
Copy Markdown
Member

Thanks @Abijeet, All looked great and functioned well.

I done a little view clear-up so we only have layout, base templates in the root of the views folder and extracted the home-sidebar into its own view since it was used in multiple files.

Thanks again, I know many people will be happy with this feature.

@ssddanbrown
ssddanbrown deleted the feature/615 branch May 20, 2018 09:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Development

Successfully merging this pull request may close these issues.

3 participants