Update entities.php for french language - #752
Merged
Merged
Conversation
Member
|
Thanks @Alwaysin, Will merge in now for the next release. I'll consider your comments on making translations easier. Not sure about leaving placeholder EN content everywhere but I'll think about a way to automate the placement process. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Follow-up of #753, sorry for separate commit!
It is very cumbersome to add translations because you have to compare and see exactly where you have to insert the strings to match the default english file. I suggest that when adding string in english you add the same to all languages with a //TODO comment so that it is easier for translators!