Skip to content

add support for gitlab authentication - #691

Merged
ssddanbrown merged 3 commits into
BookStackApp:masterfrom
pixwell-dev:support_for_gitlub_auth
Feb 4, 2018
Merged

ssddanbrown merged 3 commits into
BookStackApp:masterfrom
pixwell-dev:support_for_gitlub_auth

Conversation

@jozefbalun

Copy link
Copy Markdown
Contributor

No description provided.

@jozefbalun jozefbalun mentioned this pull request Jan 31, 2018
@lommes

lommes commented Feb 1, 2018

Copy link
Copy Markdown
Member

Thanks for your work!

I successfully tested this PR but it is missing an icon for gitlab in resources/assets/icons/gitlab.svg and it would be nice if you could ajust the keys in .env and config/services.php to match the other drivers:
.env.example

GITLAB_APP_ID=false
GITLAB_APP_SECRET=false
GITLAB_INSTANCE_URI=false

config/services.php

'gitlab' => [
        'client_id' => env('GITLAB_APP_ID'),
       'client_secret' => env('GITLAB_APP_SECRET'),
       'redirect' => env('APP_URL') . '/login/service/gitlab/callback',
       'instance_uri' => env('GITLAB_INSTANCE_URI'), // needs only for GitLab self hosted
       'name'          => 'Gitlab',
    ],

@ssddanbrown

Copy link
Copy Markdown
Member

@jozefbalun Fantastic, Thank you for your work and thank-you @lommes for reviewing this. Merged in for next release.

This was referenced Feb 4, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Development

Successfully merging this pull request may close these issues.

3 participants