Add twitch socialite auth provider - #684
Conversation
|
Forget to run a |
|
Thanks for your work! I just tested this PR and it worked for me! Only thing that would be nice is to change the keys in .env and config/services.php to match those of other services. TWITCH_KEY should become TWITCH_APP_ID The TWITCH_REDIRECT is not needed in .env since it will be the same for each install of bookstack. It can bet set in config/services.php: |
|
Made modifications following your inputs @lommes ;) |
|
There seem to be an issue with the svg file, which is displayed way too large. |
|
I reduced the icon size. Was thinking the svg was used dynamically :) |
lommes
left a comment
There was a problem hiding this comment.
I had to set width and height attribute of the svg-tag to 24 to make the icon match the button
|
In my opinion this can be merged if the icon thing is changed. |
|
Thanks both for your efforts on this! I've marked this to be in the next release. Just one thing I noticed looking over the code, The SVG icon appears to simply be a png embedded within an SVG. It would be great if this was an actual SVG drawing. I'd be happy to make that change before merging but I'll leave this open until then in case you want to make this change yourself. |
|
I'de be happy if you could do it, i'm not very familiar with svg. :) |
|
SVG updated and now merged in, Thanks, Works great! |
Followed some of the recent socialite added providers (okta, etc). It should work without any problems. If somebody could test ? 👍