Adds button to allow users to toggle the book view via the books list… - #635
Conversation
… page. Closes #613 Signed-off-by: Abijeet <abijeetpatro@gmail.com>
Signed-off-by: Abijeet <abijeetpatro@gmail.com>
| ->visit('/books') | ||
| ->pageNotHasElement('.featured-image-container') | ||
| ->pageHasElement('.entity-list-item'); | ||
| ->pageHasElement('.content .entity-list-item'); |
There was a problem hiding this comment.
Just made the test a little more specific.
|
@ssddanbrown - I think you might have a few things to add about the way I've handled this. Please let me know if you'd like me to make any changes. Also I've written the test cases but I'm not able to get them to pass. Not really sure what's wrong. Any pointers will be appreciated. Note that I've allowed even guest users to be able to toggle the view. Image below, |
|
Thanks @Abijeet for implementing this. Sorry I didn't answer your questions here and on the issue. Your implementation looked good and I agree that UserController was probably the best place for this. If found to be awkward we can always move it in the future. I done a few tweaks after pulling down and playing with it, All under commit: 141bf22 I moved the toggle to the left to separate UI options and actions which aligns it with the homepage. I changed the HTTP method to PATCH as that seemed to be the most suited to me (Since we're Thanks again! |
|
Thanks, the changes you made make sense. I will keep it in mind for future. |
2 participants
… page.
Closes #613
Signed-off-by: Abijeet abijeetpatro@gmail.com