Add socialite authentication for okta - #598
Merged
Merged
Conversation
|
We will test this, need to spin up another Okta app and test instance for PHP 7.1 Thanks for the work! |
Member
|
Thank you @chaseconey for adding this provider to socialite. And thanks @lommes for this pull request. I will merge in very soon for the next release. Only thing I'll probably change is to convert the SVG to be a full SVG rather than a png embedded in an svg. |
Member
Closed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Luckily somebody created a provider for okta some days ago, so I was able to create this pull request without much effort. I only tested with php7.1 and oktapreview.com so far, since I'm not using okta in production it would be nice if someone else could give it a try.
Documentation still missing.