Book Coverart and Grid Display - #494
Conversation
Bookstack grid view issue 181.
Revert "Bookstack grid view."
Getting latest changes
Revert "Revert "Bookstack grid view.""
…d profile setting.
… BookStackApp-master Conflicts: app/Http/Controllers/BookController.php resources/lang/en/common.php resources/views/books/create.blade.php resources/views/books/form.blade.php resources/views/books/index.blade.php resources/views/users/edit.blade.php tests/Entity/EntityTest.php
|
@ssddanbrown @Abijeet |
|
I must admit, When I saw the preview when the pull request was initially made I was very apprehensive about this feature but looking at the above gfycat preview this really does look great. Great work, Truly. Love how it fits in with the design update coming the the next release. One question, What's the different between this pull request and the other one on #434? The next release, v0.18, I think has enough new features in and is coming to a close so I'll probably look to merge this into the release after. I haven't look at the code yet but I'll have a deeper dig at merge time. |
|
@ssddanbrown - Both pull requests have the same functionality, this was made from a separate branch. @bharadwajag has gone through and updated the code based on the latest design. He has also made some improvements to it. I will close the other merge request. |
ghost
mentioned this pull request
|
This looks amazing, can it be added to the PDF too? or at least have an option to include in export to pdf |
|
Really sorry for my massive delay in reviewing this. I've now started to plan up the next release as a milestone and allocated this feature to it. The only thing I'd like to do is move the I'm happy to make this change after merging unless you want to do it beforehand? |
|
@ssddanbrown |
|
Thanks again to everyone involved with this. Now merged into master for next release. |
|
Thank you @ssddanbrown , @Abijeet and @nileshdeepak . |
4 participants
No description provided.