User preferences/options cleanup - #4615
Merged
Merged
Conversation
- Moved preference views to more general "my-account" area. - Started new layout for my-account with sidebar. - Added MFA to prefeences view (to be moved).
Text currently hard-coded, needs finalising and extracting.
Updated old user management routes to only be accessible with permission to manage users, so also removed old content controls checking for that permission.
Since management of API tokens can be accessed via two routes, this adds tracking and handling to reutrn the user to the correct place.
- Updated existing tests now affected by my-account changes. - Updated some existing tests to more accuractly check the scenario. - Updated some code styling in SocialController. - Fixed redirects for social account flows to fit my-account. - Added test for social account attaching. - Added test for api token redirect handling.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is intended to re-organise the various user options and controls, to bring all user-facing controls into a cohesive "my-account" area. This includes the creation of new "my-account" profile controls, so we can target and seperate the editing of "my-account" from that of admin controls which are intended to manage accounts that are not the current user (mostly). Means we can provide a UX intended for the seperate use-cases.
Todo
Docs Updates
Notes