-
-
Notifications
You must be signed in to change notification settings - Fork 2.4k
WIP: Book Coverart and Grid Display #434
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Closed
Closed
Changes from all commits
Commits
Show all changes
70 commits
Select commit
Hold shift + click to select a range
6557fbb
commit
nileshdeepak 8924618
test
nileshdeepak af72f0d
Bookstack grid view.
nileshdeepak fdf139e
Changing column size for responsiveness
nileshdeepak bce5fdd
Merge branch 'master' into issue-181
nileshdeepak 947c58f
Applied required changes in BookStack.
nileshdeepak d99fd1f
Applied required changes
nileshdeepak bb2d859
Removed duplicated styles.
nileshdeepak d089eaf
Changes in User edit profile page.
nileshdeepak e10d4b9
styles.scss
nileshdeepak 026de8c
Thumbnail toggle function.
nileshdeepak 6eccb3d
Adding new migration.
nileshdeepak e88a062
Updated toggle thumbnails function.
nileshdeepak cc553cc
Added labels for 'Thumbnail toggle' and 'Cover image' in different la…
nileshdeepak 5b736c3
Updated views to support different languages.
nileshdeepak 6ad24a6
Changed public getImageURL function to private.
nileshdeepak f51db4b
Resolved responsiveness issues
nileshdeepak 16a09e8
Deletion of image file on book deletion.
nileshdeepak c5f11e4
Fixed pagination on change of display type.
nileshdeepak 144a6e4
Updated cover image upload and delete function.
nileshdeepak d84315f
Indentation correction.
nileshdeepak a663fc8
Merge pull request #1 from OsmosysSoftware/issue-181
nileshdeepak 3fd61a3
Revert "Bookstack grid view."
AbijeetP 0ed3023
Merge pull request #3 from OsmosysSoftware/revert-1-issue-181
AbijeetP f0d914a
Merge pull request #5 from BookStackApp/master
AbijeetP 844976c
Revert "Revert "Bookstack grid view.""
AbijeetP f3b2e0f
Merge pull request #7 from OsmosysSoftware/revert-3-revert-1-issue-181
AbijeetP 7a724f9
Updated modifications.
nileshdeepak d37b398
Updates styles.
nileshdeepak 24ee78c
Update.
nileshdeepak f375090
Merge pull request #8 from OsmosysSoftware/feature-181
AbijeetP e919cab
1. Thumbnail size when creating or editing book.
nileshdeepak b0ba1a4
2. Added classed col-xs-6 col-sm-4 col-md-4 col-lg-3 in grid-item.bla…
nileshdeepak ab6ff5f
3. New default.png
nileshdeepak afc1eca
4. Changed the border color of the gallery item to #ccc
nileshdeepak 7f8351e
Removed avatar class from form.blade.php
nileshdeepak 21a8df7
Merge pull request #9 from OsmosysSoftware/feature-181
AbijeetP 8f3adcd
Cover image test case
nileshdeepak 1fe8f13
Cover image test case
nileshdeepak 6a6516d
Test for layout selection.
nileshdeepak 1278a0b
Test for layout selection.
nileshdeepak fd36978
Test for layout selection.
nileshdeepak 1ed74b8
Test for grid and list layout selection.
nileshdeepak 3435dcc
Merge pull request #10 from OsmosysSoftware/test-issue-181
AbijeetP 832f8ea
Fixes the test case related to UserProfileTest.
AbijeetP 85fbe82
Adding getHeadingExcerpt to get heading.
nileshdeepak e5dc0e6
Merge branch 'master' of https://github.com/OsmosysSoftware/BookStack
nileshdeepak dd4d2f4
Resolves book heading issues in grid view.
nileshdeepak 9872767
Test for cover image upload
nileshdeepak b4044e6
Resolves heading issues in grid view
nileshdeepak 770f30c
Test books display options.
nileshdeepak 0c70416
Test books display options.
nileshdeepak 922964e
Changes grid container size
nileshdeepak 6d66c38
Fixes issues with the test case, now creating a user with the require…
AbijeetP a488ef6
Test for cover image.
nileshdeepak 39b924f
Merge branch 'master' of https://github.com/OsmosysSoftware/BookStack
nileshdeepak 3d808ac
Test for cover image
nileshdeepak 854fd52
Resolving test cases
nileshdeepak a149e87
Resolving test cases
nileshdeepak a7d2cfd
Resolving test cases
nileshdeepak 3079a9f
Reverted required changes.
nileshdeepak 7f902e4
Resolved conflicts
4bb97b6
Merge branch 'BookStackApp-master'
6200948
Merge branch 'master' of git://github.com/BookStackApp/BookStack into…
ac12b44
Merge branch 'BookStackApp-master'
c1a1bc0
Books grid view
1c88d21
Fixed books cover image ratio.
e02fcbe
Added Book cover image description in all languages.
939968e
Merge pull request #13 from OsmosysSoftware/BookStackApp-master
AbijeetP 66b260d
Merge pull request #14 from BookStackApp/master
bharadwajag File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
40 changes: 40 additions & 0 deletions
40
database/migrations/2017_07_05_102650_add_cover_image_display.php
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,40 @@ | ||
| <?php | ||
|
|
||
| use Illuminate\Support\Facades\Schema; | ||
| use Illuminate\Database\Schema\Blueprint; | ||
| use Illuminate\Database\Migrations\Migration; | ||
|
|
||
| class AddCoverImageDisplay extends Migration | ||
| { | ||
| /** | ||
| * Run the migrations. | ||
| * | ||
| * @return void | ||
| */ | ||
| public function up() | ||
| { | ||
| Schema::table('users', function (Blueprint $table) { | ||
| $table->string('books_display',10)->default('grid'); | ||
| }); | ||
|
|
||
| Schema::table('books', function (Blueprint $table) { | ||
| $table->integer('image'); | ||
|
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more.
|
||
| }); | ||
| } | ||
|
|
||
| /** | ||
| * Reverse the migrations. | ||
| * | ||
| * @return void | ||
| */ | ||
| public function down() | ||
| { | ||
| Schema::table('users', function (Blueprint $table) { | ||
| $table->dropColumn('books_display'); | ||
| }); | ||
|
|
||
| Schema::table('books', function (Blueprint $table) { | ||
| $table->dropColumn('image'); | ||
| }); | ||
| } | ||
| } | ||
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -102,6 +102,19 @@ jQuery.expr[":"].contains = $.expr.createPseudo(function (arg) { | |
| }; | ||
| }); | ||
|
|
||
| // Common jQuery actions | ||
| $('[data-action="expand-entity-list-details"]').click(function() { | ||
| $('.entity-list.compact').find('p').not('.empty-text').slideToggle(240); | ||
| }); | ||
|
|
||
| // Toggle thumbnail::hide image and reduce grid size | ||
| $(document).ready(function(){ | ||
|
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. We don't need |
||
| $('[data-action="expand-thumbnail"]').click(function(){ | ||
| $('.gallery-item').toggleClass("collapse").find('img').slideToggle(50); | ||
| }); | ||
| }); | ||
|
|
||
|
|
||
| // Detect IE for css | ||
| if(navigator.userAgent.indexOf('MSIE')!==-1 | ||
| || navigator.appVersion.indexOf('Trident/') > 0 | ||
|
|
||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
'books_display'can we rename it to something better like 'books_view_type'.