changed PageContent.php to accept nested includes - #4192
Conversation
…evels. Tested it and it works.
|
hi @ssddanbrown, could you please review this pull request? Thanks in Advance. |
|
Thanks @jasonF1000 for offering this PR. A few of things:
There are existing tests to cover page includes in this file: Note-to-selfIf merged, this will need to be documented as a breaking change. |
This loop is now only around parsePageIncludes and bugfixes the space indentation.
|
Hi @ssddanbrown i followed your recommendation and fixed the space issue and change the loop that it is only around the parsePageIncludes. But i feel not so comfortable to add the testings, therefore i have to low experience with PHP. Sorry :( |
fix spaces
|
Thanks @jasonF1000, now merged for next release. |
|
@ssddanbrown thank you for taking over the testing part and for the implementation of the feature :) |
tested and it works.
We have implemented levels depths that can be configured as needed. ( via includeDepth variable)
This solves issue #2845