Skip to content

Global search live preview - #3850

Merged
ssddanbrown merged 7 commits into
developmentfrom
search_preview
Nov 23, 2022
Merged

ssddanbrown merged 7 commits into
developmentfrom
search_preview

Conversation

@ssddanbrown

@ssddanbrown ssddanbrown commented Nov 14, 2022

Copy link
Copy Markdown
Member

Addition of search results live preview while typing in global search box.

Related to #1235.

Todo

  • Proper Handling of empty search results
  • Maybe dedicated endpoint for easier results formatting and limiting.
  • Handle removal of preview on blur/click of list (via CSS focus-within?)
  • Correct input shading on suggestions show.
  • Disable browser history/suggestions by default to prevent visual conflict.
  • Provide method to show browser suggestions/history (Double click in input?)
  • Add debounce of input handling.
  • Arrow key and escape handling.
  • Dark mode check
  • Testing of any new endpoints

@ssddanbrown
ssddanbrown merged commit ffc9c28 into development Nov 23, 2022
@ssddanbrown ssddanbrown mentioned this pull request Nov 23, 2022
@ssddanbrown
ssddanbrown deleted the search_preview branch February 23, 2023 23:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Development

Successfully merging this pull request may close these issues.

1 participant