Chapter and Book Conversion Actions - #3499
Merged
Merged
Conversation
- Updates book/shelf cover image handling for easier cloning/handling. - Adds core logic for promoting books/chapters up a level. - Enables usage of book/shelf cover image via API. Related to #1087
- Added required UI within edit view. - Added required routes and controller actions.
- Also extracted shelf to book view elements to own partial. - Fixed some existing logic including image param handling in update request and activity logging against correct element.
Also updated cloner class with typed properties.
- Updated 'removePermissionFromUser' test helper to work for entity-permissions that become part of the joint permissions system.
1 task
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is primarily intended to add actions for converting chapters to books, and books to shelves as per #1087.
Considerations
Pagesappended to the name and this book will be added to the new "Converted" shelf.TODO
These are in-addition to the in-code todos.