Skip to content

Bunch of tiny improvements - #3433

Merged
ssddanbrown merged 21 commits into
developmentfrom
tiny_improvements
May 30, 2022
Merged

ssddanbrown merged 21 commits into
developmentfrom
tiny_improvements

Conversation

@ssddanbrown

@ssddanbrown ssddanbrown commented May 13, 2022

Copy link
Copy Markdown
Member

Just opening this PR to track a set of smaller changes.

Changes

  • Reduced excess margins in chapter contents list.
  • Updated tri-layout sidebars to not be cut-off by padding.
  • Improved input size consistency. Related to Audit log inputs heights and paddings are inconsistent  #2678.
  • Fixed skip-to-content link shadow being slightly visible.
  • Improved the display of dropdown menus:
    • Tweaked styling to add a little extra shadow and be more rounded to
      match other UI areas.
    • Added slight horizontal inset when in right sidebar to prevent shadow
      being cut-off in most cases.
    • Added logic to "drop upwards" if dropping down would take the menu
      offscreen.
  • Cleaned up content details section:
    • Prevented wrapping around icon.
    • Updated font-size to match other UI content.
    • Updated spacing and line-heights to be a tad better laid-out.
  • Tidied up book navigation sidebar styles:
    • Removed background track line since it would darken entity item bars.
    • Updated item spacing to be a bit tighter.
    • Updated action hover styles to be a bit lighter, and visible on dark
      mode, to fit rest of system.
  • Improved card list design:
    • Removed border and rounded list item styles to make hover states have
      less edge detail and to align with other UI elements.
    • In expanded-detail view, removed space used for entity description if
      there is not description content existing.
  • Updated breadcrumb dropdown styles, improved keyboard nav:
    • Removed harsh theme color border between search and content.
    • Prevented intermediate focus on list container to align arrow & tab
      behavior, and to get to content quicker.
  • Refined header bar styles:
    • Updated many items to be flexbox-based.
    • Updated & aligned hover states across header bar items.
  • Aligned collapsed header dropdown item styles.
  • Made the "Custom HTML Head Content" setting a highlighted code editor.
  • Tweaked chapter list item styles:
    • Improves animation smoothness.
    • Cleaned spacing to match page items in books listing.
  • Made chapter toggle in book sidebar nav more consistent.
  • Updated attachment links to have dropdown for open type for easier inline usage access.

- Tweaked styling to add a little extra shadow and be more rounded to
  match other UI areas.
- Added slight horizontal inset when in right sidebar to prevent shadow
  being cut-off in most cases.
- Added logic to "drop upwards" if dropping down would take the menu
  offscreen.
- Removed background track line since it would darken entity item bars.
- Updated item spacing to be a bit tighter.
- Updated action hover styles to be a bit lighter, and visible on dark
  mode, to fit rest of system.
- Removed border and rounded list item styles to make hover states have
  less edge detail and to align with other UI elements.
- In expanded-detail view, removed space used for entity description if
  there is not description content existing.
- Removed harsh theme color border between search and content.
- Prevented intermediate focus on list container to align arrow & tab
  behaviour, and to get to content quicker.
Loading animation would show in an unready state due to animation-delay
on components. Updated to a negative delay to ensure elements were in
correct positions right away upon show.
Animates the height on breadcrumb dropdown menus to transition to the
loaded animations quicker. Includes a new animation helper for doing
similar tasks in future.
Would cause effect where scroll area would be cut of by spacing which
looked a bit strange. This retains the same padding sizes but cuts the
content at the header or top of viewport.
Would cause a slight dark area in top left of view while hidden.
Specifically updates dropdown search and user-search implementation,
although does affect all inputs.
Decouples breadcrum and select-style dropdown search toggles.

Addresses #2678
- Updated many items to be flexbox-based.
- Updated & aligned hover states across header bar items.
Previously the desktop-visible items would style different when collapsed
into the expanded dropdown menu, compared to existing items.
- Improves animation smoothness
- Changed animation slideup/down animations to use max-height instead of height
  to better avoid jutter at the end.
- Cleaned spacing to match page items in books listing.
Was extra space showing due to structure changes and flex gap.
- Now has a hover state to match other items.
- Now spans the full sidebar with like other items.
- Also updated chapter-toggle to a chapter-contents component, following
  the newer component system.
- Allows easier accessibility of inline attachments.
- Introduces a new split-icon-list-item thingy to support such cases
  where only part of the button is actually linked.
@ssddanbrown ssddanbrown self-assigned this May 30, 2022
@ssddanbrown
ssddanbrown merged commit 6ce34fe into development May 30, 2022
@ssddanbrown
ssddanbrown deleted the tiny_improvements branch May 30, 2022 15:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Development

Successfully merging this pull request may close these issues.

1 participant