Skip intermediate login page with single provider - #3406
Merged
ssddanbrown merged 1 commit intoJun 21, 2022
Merged
Conversation
2 tasks
|
I have applied these changes and can confirm that its working in version 22.02.3 |
+1 I tried these on top of 22.04.2 and work as expected. |
ssddanbrown
added a commit
that referenced
this pull request
Jun 21, 2022
For PR #3406 - Updated naming from 'redirect' to 'initate/initation'. - Updated phpunit.xml and .env.example.complete files with the new option. - Cleaned up controller logic a bit. - Added content and design to the new initation view to not leave user on a blank view for a while. - Added non-JS button to initiation view as fallback option for progression. - Moved new test to it's own Test class and expanded with additional scenario tests for better functionality coverage.
Member
|
Thank you very much for this @rjmidau. All looked good. I did follow this up with a set of changes in 8b211ed. These were primarily naming changes in addition to expanding tests and making the new intermediate view an actual view with content & loading animation, with a manual-non-js option to trigger the authentication form submission as a backup. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Resolves #3216, #2175
When a single authentication provider is configured, it is now possible to skip the intermediate user interaction on the /login page and redirect directly to the auth provider's actual login page, saving an extra click for users.
This new behaviour is disabled by default, and can be enabled by setting the AUTH_AUTO_REDIRECT environment variable to true.
This new behaviour only works for saml2 and oidc providers, and will not work if Social Auth providers are enabled.
This new behaviour will not be honoured for /login if argument ?logout=1 is passed (which is where users are redirected to after logout when AUTH_AUTO_REDIRECT is set to true).
This also introduces an overridden logout() function so post-logout redirection can be honoured (it appears redirectAfterLogout has not been honoured in Laravel since ~5.3 - see laravel/framework#15525)