Skip to content

enh(recently updated): show updatedBy and updated_at - #3177

Merged
ssddanbrown merged 1 commit into
BookStackApp:masterfrom
bourdaisj:show_more_informations_on_recently_updated_pages
Jan 24, 2022
Merged

ssddanbrown merged 1 commit into
BookStackApp:masterfrom
bourdaisj:show_more_informations_on_recently_updated_pages

Conversation

@bourdaisj

Copy link
Copy Markdown
Contributor

See #3045 for informations

@bourdaisj
bourdaisj force-pushed the show_more_informations_on_recently_updated_pages branch 2 times, most recently from bf34136 to 259d499 Compare January 18, 2022 22:13
@mlipok

mlipok commented Jan 18, 2022

Copy link
Copy Markdown

I just sent it to my WebDev to check this.

@bourdaisj
bourdaisj force-pushed the show_more_informations_on_recently_updated_pages branch from 259d499 to 6db6476 Compare January 19, 2022 20:53
@bourdaisj
bourdaisj marked this pull request as ready for review January 19, 2022 20:57
@mlipok

mlipok commented Jan 20, 2022

Copy link
Copy Markdown

It looks good for me:
image

@mlipok

mlipok commented Jan 20, 2022

Copy link
Copy Markdown

btw.
As you can see this shows only "Page" name for example "TYMCZASOWE" or "Screenshoty"
could you also think about adding a feature to provide more precise localization something like "Shelf / Book / Chapter / Page"

btw.
Should I open new FeatureRequest for this ?

@bourdaisj

Copy link
Copy Markdown
Contributor Author

It may be out of scope for this PR but this could be a useful enhancement imo. Waiting for insights from the maintainers about this

@mlipok

mlipok commented Jan 20, 2022

Copy link
Copy Markdown

So I open new FeatureRequest

@ssddanbrown

Copy link
Copy Markdown
Member

Thanks for this @Julesdevops, All looked great. I followed this up with a test to cover the change in aae3cd6.

Merged to be part of the next patch release.

@bourdaisj

Copy link
Copy Markdown
Contributor Author

Thanks, and apologies for the missing test, totally forgot for this one

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Development

Successfully merging this pull request may close these issues.

3 participants