Initial Webhook Implementation - #3099
Merged
Merged
Conversation
Got webhook CRUD actions in place within the interface. Quick manual test pass done, Needs automated tests.
- Renamed to "ActivityLogger" to be more focused in usage. - Extracted out query elements to seperate "ActivityQueries" class. - Removed old 'addForEntity' activity method to limit activity record points.
To allow easy temporary de-activation without deletion or other workarounds. Updated tests to cover.
Migrated call logic to Laravel's HTTP client for easier testing capabilities.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The PR tracks an initial implementation for outbound webhooks. This will adhere-to/include the following:
eventproperty will detail the event that was trigged.textproperty will be set where possible to provide a human readable description of the event for potential direct slack (Or slack compatible) usage.TODO
Queue Strategy
Defaults to
sync. Can use an async queue viaQUEUE_CONNECTION=sync. Will then need a queue worker via:Ideally will need that ran via systemd or similar, with
php artisan queue:restartran upon update.Docs Todo