Skip to content

Modernize third party services' logos - #3032

Merged
ssddanbrown merged 1 commit into
BookStackApp:masterfrom
na3shkw:modernize-3rd-party-service-logos
Nov 4, 2021
Merged

ssddanbrown merged 1 commit into
BookStackApp:masterfrom
na3shkw:modernize-3rd-party-service-logos

Conversation

@na3shkw

@na3shkw na3shkw commented Nov 1, 2021

Copy link
Copy Markdown
Contributor

login_screen_diff

Facebook and Slack have updated their app logos in 2019. This pull request will update the old logos currently in use to the latest ones.

Logo sources

@ssddanbrown

Copy link
Copy Markdown
Member

@na3shkw Awesome, thanks for this! Have assigned to the next feature release.

ssddanbrown added a commit that referenced this pull request Nov 4, 2021
Both were using the same class names causing a quadrant of the slack logo
to be the discord brand color.

Related to #3032
@ssddanbrown
ssddanbrown merged commit b9a5885 into BookStackApp:master Nov 4, 2021
@ssddanbrown

Copy link
Copy Markdown
Member

Thanks again @na3shkw, Now merged for next feature release.

This change did cause a classname clash to appear, which would dis-color the slack logo if the discord auth option was present, hence I followed this up with 1eed8d6 to amend.

@na3shkw
na3shkw deleted the modernize-3rd-party-service-logos branch November 5, 2021 11:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Development

Successfully merging this pull request may close these issues.

2 participants