[sec] Fixes a few minor vulnerabilies when using target="_blank" on links (RSPEC-5148) - #2768
Merged
ssddanbrown merged 1 commit intoMay 24, 2021
Merged
Conversation
Member
|
Thanks for this @CorruptComputer. Most of these are internal, hence wouldn't really matter, but there are a few potential external ones in there that could be prone to such scenarios. Will merge in now for the next feature release. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Using
target="_blank"on links without addingrel="noopener"can be a minor vulnerability.See RSPEC-5148 for more info on the specifics of the issue.
This is not really an issue on most up to date browsers (Chrome 88+, Firefox 79+ or Safari 12.1+) though I think its always best to program defensively since you don't know what browser the end users will end up using.
If you don't see any benefit in adding this feel free to close.