Sort Books within Shelves - #2515
Merged
ssddanbrown merged 2 commits intoMar 21, 2021
Merged
Conversation
ssddanbrown
requested changes
Jan 30, 2021
ssddanbrown
left a comment
ssddanbrown
left a comment
Member
There was a problem hiding this comment.
Thanks for offering this PR @guillaumehanotel.
I've added my thoughts during initial review of the changes. We'll also need to ensure these changes are covered with some level of testing.
guillaumehanotel
force-pushed
the
feature/sort-shelf-books
branch
from
January 31, 2021 03:28
b4dd49c to
a7848b9
Compare
|
Looking forward to this change |
ssddanbrown
added a commit
that referenced
this pull request
Mar 21, 2021
Done during review of #2515
Member
|
Thanks for attempted some of those changes. I've finished this off and added testing in 5c9c1d1. This is now merged, to be part of the next feature release. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hello,
as referred in the issue #1742 , I've added the possibility to sort books within shelves.
Please give me your feedback